odb_mkstemp's 0444 permission broke write/delete access on AFP
- From
- Fairuzan Roslan <fairuzan.roslan@gmail.com>
- Date
- Feb 16, 2015, 17:54 UTC
- Message-ID
- <A403BFCC-D66F-49BD-B54C-BB86B467F1A1@gmail.com>
Hi,
Somehow the “int mode = 0444;” in odb_mkstemp (environment.c) are causing a lot of issues (unable to unlink/write/rename) to those people who use AFP shares.
In order to be able to write/unlink/delete/rename a file on AFP filesystem the owner of the file must have at least a u+w access to it.
The issue was first introduced in https://github.com/git/git/blob/f80c7ae8fe9c0f3ce93c96a2dccaba34e456e33a/wrapper.c line 284.
To fix these issues the permission need to be adjusted to “int mode = 0644;” in odb_mkstemp (environment.c)
Please let me know if you need further detail.
Regards, Fairuzan