Re: [PATCH v1] travis-ci: ask homebrew for the its path instead of hardcoding it

From: Lars Schneider <larsxschneider@gmail.com>
Date: Sep 22, 2016, 09:03 UTC
Message-ID: <A1C0644E-095A-4903-AE86-72EAEFEB385B@gmail.com>
In-Reply-To: <xmqqzin19pbj.fsf@gitster.mtv.corp.google.com>

Show 24 quoted lines

> On 21 Sep 2016, at 18:42, Junio C Hamano <gitster@pobox.com> wrote:
> 
> Lars Schneider <larsxschneider@gmail.com> writes:
> 
>>> On 21 Sep 2016, at 11:31, stefan.naewe@atlas-elektronik.com wrote:
>>> 
>>> In the Subject: s/the //
>>> 
>>> Am 21.09.2016 um 10:45 schrieb larsxschneider@gmail.com:
>>>> From: Lars Schneider <larsxschneider@gmail.com>
>>>> 
>>>> The TravisCI macOS build is broken because homebrew (a macOS depedency
>>> 
>>> s/depedency/dependency/
>> 
>> Thanks for spotting both errors!
>> 
>> @Junio: Should I make a v2?
> 
> No.  osx before_install stuff was in there since the very beginning,
> i.e. 522354d7 ("Add Travis CI support", 2015-11-27), so I guess this
> needs to go to maint-2.7 and upwards, but I guess we should discourage
> people to stay on an older maintenance track forever, so let's do
> this only for 'maint' and upwards.

Sound good to me.

Thank you, Lars

Minor nit: If still possible and no trouble for you please do `s/the //` on the subject line of 72fa5cd29f2a9249462215109dbf41b4a6c0c768 (in PU)