git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] compat/mingw.h: drop extern from function declaration

From
Denton Liu <liu.denton@gmail.com>
Date
Oct 7, 2020, 08:31 UTC
Message-ID
<9e5a8625cab217bd6aaba68da081bc801354b903.1602059508.git.liu.denton@gmail.com>

In 554544276a (*.[ch]: remove extern from function declarations using spatch, 2019-04-29), `extern` on function declarations were declared to be redundant and thus removed from the codebase. An `extern` was accidentally reintroduced in 08809c09aa (mingw: add a helper function to attach GDB to the current process, 2020-02-13).

Remove this spurious `extern`.
Signed-off-by: Denton Liu <liu.denton@gmail.com>
---
Notes:
    This patch is based on 554544276a, formerly 'js/mingw-open-in-gdb'.
 compat/mingw.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/compat/mingw.h b/compat/mingw.h
index 88c07c4520..5c34547539 100644
--- a/compat/mingw.h
+++ b/compat/mingw.h
@@ -599,7 +599,7 @@ int main(int argc, const char **argv);
  * Call this function to open a new MinTTY (this assumes you are in Git for
  * Windows' SDK) with a GDB that attaches to the current process right away.
  */
-extern void open_in_gdb(void);
+void open_in_gdb(void);
 
 /*
  * Used by Pthread API implementation for Windows
-- 
2.28.0.942.g77c4c6094c
Next: Johannes Schindelin
Message 1 of 7 in “compat/mingw.h: drop extern from function declaration”
  1. compat/mingw.h: drop extern from function declarationDenton Liu, Oct 7, 2020
  2. Johannes SchindelinOct 7, 2020
  3. Makefile: create externcheck targetDenton Liu, Oct 8, 2020
  4. Johannes SchindelinOct 8, 2020
  5. Denton LiuOct 8, 2020
  6. Johannes SchindelinOct 8, 2020
  7. Junio C HamanoOct 9, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.