Re: New mailmap file for the kernel
- From
Jon Smirl <jonsmirl@gmail.com>
- Date
- Jul 28, 2008, 12:47 UTC
- Message-ID
- <9e4733910807280547w70256962o6f51b48f66cdd0b1@mail.gmail.com>
- In-Reply-To
- <bd6139dc0807280453rbfc28ffid8314e74cc19b7f7@mail.gmail.com>
On 7/28/08, Sverre Rabbelier <alturin@gmail.com> wrote:
Show 11 quoted lines
> On Mon, Jul 28, 2008 at 13:23, Johannes Schindelin > > <Johannes.Schindelin@gmx.de> wrote: > > > And how exactly do you plan to make sure everybody has that hook > > installed? > > > It needn't be installed with everybody, only at the people that form > 'upstream' (in the git case that'd be Junio, in the Linux case that'd > be Linus and his lieutenants).
That's the idea. The lieutenants would have the hook and stop anything that introduced new errors into the file. checkpatch.pl would get the same hook. And we'd make it available to all developers too. Someone want to help out are write the hook? My hands hurt from editing the mailmap file for too long.
We really need a hook to start the validation process. Putting all of the existing names in the file makes it easier to write the hook. I was surprised that 12% of all names in the log had errors in them. That's a terrible error rate.
Making sure nothing slips through is not that bad. Use git log to extract all email addresses. Run a script to ensure that they are all in the mail map file.Add the missing ones, there should only be a few. If the commit validation process works there shouldn't be any.
It's not just statistics, what it we had to contact everyone because of some licensing or patent mess? Mozilla has had to contact everyone three times now.
Bottom line this is Linus' call. Does he want a validation mechanism for names and email addresses in the log?
Show 23 quoted lines
> > Also, it would be a major hassle, just for the benefits of statistics > > (which, funnily enough, not everybody cares about). > > > Hmmm, I'm not sure if it would be a major hassle once it's set up? > Once everybody has their name correctly in the mailmap nobody will > have to care? > > > > But we are not truly distributed. Our community is small enough, and our > > maintainer good enough, that we do have a single upstream essentially. We > > do not even have lieutenants through which new developers could come (and > > therefore would be old developers once they hit master). > > > Ah, I did not realize that. Thanks for explaining. > > -- > Cheers, > > > Sverre Rabbelier >
-- Jon Smirl jonsmirl@gmail.com