Re: Calculating tree nodes

From: Jon Smirl <jonsmirl@gmail.com>
Date: Sep 4, 2007, 14:31 UTC
Message-ID: <9e4733910709040731s2695ab14kb9750923fcac007@mail.gmail.com>
In-Reply-To: <Pine.LNX.4.64.0709041131030.28586@racer.site>

On 9/4/07, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 12 quoted lines

> Hi,
>
> On Tue, 4 Sep 2007, Jon Smirl wrote:
>
> > In my scheme the path info is moved into the file object nodes and the
> > SHA list is in the commit node.
>
> And how should this "SHA list" be any different from a single tree object,
> except that you now merge it with the commit object?
>
> Really, go back to the mail Martin mentioned.  Having all objects in one
> list kills performance.

You are ignoring the fact the in this scheme temp indexes can be created as needed. These temp indexes could look just like tree nodes.

I'm saying that it may be a mistake to be recording the indexes (aka file names) as part of the commit when they really aren't. The essential part of the commit is the SHA1 list. The path names belong to the file objects and should be stored there.

Show 11 quoted lines

>
> > Diffing two trees in the scheme is quite fast. Just get their commit
> > objects into RAM and compare the lists of SHAs.
>
> No, it is not fast.  Just loading the complete list into RAM is likely
> much, much slower than a simple diff _right_ _now_.
>
> Hth,
> Dscho
>
>

-- 
Jon Smirl
jonsmirl@gmail.com