Error in nct7802.c
- From
- Латышев Сергей Александрович <latyshevsa@nic-t.ru>
- Date
- Sep 3, 2025, 12:59 UTC
- Message-ID
- <9e0ae524-096f-4629-b3bd-5a100f6790ef@nic-t.ru>
Hello, An error was found in the code of the drivers/hwmon/nct7802.c file. A macro mismatch on line 49 #define SMARTFI_EN_SHIFT(x) ((x) %2 *4) of the chip documentation dated 02.2020 in Table No. 7.2.95 "Temperature to Fan mapping Relationships Register".
I suggest this simple variant: #define SMARTFI_EN_SHIFT(x) (((x)==0)?0:(((x)==1)?5:2))