Re: [PATCH] send-email: explicitly disable authentication

From: Joshua Watt <jpewhacker@gmail.com>
Date: Oct 18, 2018, 22:01 UTC
Message-ID: <9dc2995ff84158450255478c7411339a81f63aba.camel@gmail.com>
In-Reply-To: <CAPig+cR27mPmH+0oeT+2T878K-cBNqBnxPUumETnVK1cvz2qnA@mail.gmail.com>

On Thu, 2018-10-18 at 17:53 -0400, Eric Sunshine wrote:

Show 17 quoted lines

> On Thu, Oct 18, 2018 at 5:16 PM Joshua Watt <jpewhacker@gmail.com>
> wrote:
> > It can be necessary to disable SMTP authentication by a mechanism
> > other
> > than sendemail.smtpuser being undefined. For example, if the user
> > has
> > sendemail.smtpuser set globally but wants to disable authentication
> > locally in one repository.
> > 
> > --smtp-auth and sendemail.smtpauth now understand the value 'none'
> > which
> > means to disable authentication completely, even if an
> > authentication
> > user is specified.
> 
> Implementation complexity aside, spelling the option --no-smtp-auth
> might be more intuitive and consistent than --smtp-auth=none.

One advantage of --smtp-auth=none is that it can also be done with a config variable sendemail.smtpauth="none". Would be also add a config variable like sendemail.nosmtpauth (the negative seems strange to me)?

Or maybe --no-smtp-auth is just a shorthand alias for --smtp-auth=none?

Show 5 quoted lines

> 
> > The value 'none' is lower case to avoid conflicts with any RFC 4422
> > authentication mechanisms.
> > 
> > Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>

-- 
Joshua Watt <JPEWhacker@gmail.com>