Re: [PATCH] exec_cmd: RUNTIME_PREFIX on OpenBSD systems

From: Johannes Sixt <j6t@kdbg.org>
Date: Sep 21, 2026, 16:43 UTC
Message-ID: <9d1ac51b-9969-49a1-a911-7669872d28c4@kdbg.org>
In-Reply-To: <CAPx1Gvco17vf-rmQsqumLdX8Gcjnu0Qx=e7_PdFw0p7BDRLU7Q@mail.gmail.com>

Am 21.09.26 um 15:00 schrieb Chris Torek:

Show 20 quoted lines

> [Ugh, somehow plain text mode got turned off, re-sending]
> 
> On Wed, Sep 16, 2026 at 8:41 PM Brad Smith <brad@comstyle.com> wrote:
>>
>> @@ -209,6 +229,10 @@ static int git_get_exec_path(struct strbuf *buf, const char *argv0)
>>          * after the first successful method.
>>          */
>>         if (
>> +#ifdef HAVE_GETEXECPATH
>> +               git_get_exec_path_getexecpath(buf) &&
>> +#endif /* HAVE_GETEXECPATH */
>> +
>>  #ifdef HAVE_BSD_KERN_PROC_SYSCTL
>>                 git_get_exec_path_bsd_sysctl(buf) &&
>>  #endif /* HAVE_BSD_KERN_PROC_SYSCTL */
>> --
>> 2.55.0
> 
> Sort of a minor nit, but given this code construct, there should probably be
> instructions saying to define only one of these.

This caught me too. But notice that the calls are chained by && so that the first successful call determines the outcome.

-- Hannes