git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Breaking change with "git log -n" since 2.43

From
Kristoffer Haugsbakk <code@khaugsbakk.name>
Date
Feb 21, 2024, 13:55 UTC
Message-ID
<9c52ea4e-f84e-4c64-977d-14a468236c80@app.fastmail.com>
In-Reply-To
<CAB=tB2vB0LbP=DznSqTFYHCRxDxd6U=Q+P33yeBzGssq2eK1vA@mail.gmail.com>
On Wed, Feb 21, 2024, at 14:32, Maarten Ackermans wrote:
Show 22 quoted lines
> Hi all,
>
> I would like to report a breaking change with "git log -n" introduced
> in 2.43 that's causing some trouble:
> https://github.com/git/git/commit/71a1e94821666909b7b2bd62a36244c601f8430e#diff-380c4eac267b5af349ace88c78a2b004a16ed20c2b605c76827981063924bbf9R2222
>
> To reproduce, the command `git log -n 9007199254740991` fails on
> 2.43.2, whereas it didn't on 2.42.0. This specific number corresponds
> to the Number.MAX_SAFE_INTEGER (2^53 - 1) in JavaScript (docs:
> https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/MAX_SAFE_INTEGER).
> The max value that is supported now is a signed 32-bit integer (2^31 -
> 1).
>
> I suppose git simply ignored the extra digits of the number, as the
> commit message describes.
>
> See https://github.com/intuit/auto/issues/2425#issuecomment-1956557071
> for the impact.
>
> Best regards,
>
> Maarten Ackermans

I don’t see how this is a breaking change considering the range is not documented.

-- 
Kristoffer Haugsbakk
Previous: Maarten AckermansNext: Maarten Ackermans
Message 2 of 10 in “Breaking change with "git log -n" since 2.43”
  1. Maarten AckermansFeb 21, 2024
  2. Kristoffer HaugsbakkFeb 21, 2024
  3. Maarten AckermansFeb 21, 2024
  4. Sean AllredFeb 21, 2024
  5. Maarten AckermansFeb 21, 2024
  6. Sean AllredFeb 21, 2024
  7. Kristoffer HaugsbakkFeb 21, 2024
  8. Kristoffer HaugsbakkFeb 21, 2024
  9. Jeff KingFeb 21, 2024
  10. Sean AllredFeb 21, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.