Re: [PATCH 1/2] test-lib-functions: use user's SHELL, HOME and TERM for 'test_pause'
Hi Carlo,
Le 2021-08-19 à 23:08, Carlo Arenas a écrit :
Show 11 quoted lines
> On Thu, Aug 19, 2021 at 10:17 AM Philippe Blain via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
>>
>> From: Philippe Blain <levraiphilippeblain@gmail.com>
>>
>> The 'test_pause' function, which is designed to help interactive
>> debugging and exploration of tests, currently inherits the value of HOME
>> and TERM set by 'test-lib.sh': HOME="$TRASH_DIRECTORY" and TERM=dumb. It
>> also invokes the shell defined by SHELL_PATH, which defaults to /bin/sh.
>
> that is a bug, it should have been TEST_SHELL_PATH instead.
Right. I'll make that change unconditionnally as a preparatory step.
>
> goes without saying, that if you don't really need that shell for your
> interactive session, nothing prevents you from calling bash and
> resetting TERM or even HOME as needed
Yes. I'm just trying to streamline to experience :)
Philippe Blain <levraiphilippeblain@gmail.com>