Re: extra headers in commit objects
- From
- demerphq <demerphq@gmail.com>
- Date
- Feb 3, 2010, 19:43 UTC
- Message-ID
- <9b18b3111002031143h63aaa6bpa4c91d140a769bb0@mail.gmail.com>
- In-Reply-To
- <20100203192658.GP9553@machine.or.cz>
On 3 February 2010 20:26, Petr Baudis <pasky@suse.cz> wrote:
Show 13 quoted lines
> On Wed, Feb 03, 2010 at 08:01:17PM +0100, demerphq wrote: >> Shouldn't an old git just ignore headers from a new git? >> >> I mean, forget about the fact that somebody is doing something naughty >> with the git protocol, ask youself if you want this rule to basically >> prevent any backwards compatible changes with older gits. > > We have done similar changes in the past and if there would be such > a change, we can phase-in it over the course of several releases. > I think the fall-out would not be that bad; we have some experience > with even making Debian-stable Git compatible with new stuff. ;-) > Also, what if any extra header would be essential and we _wanted_ > non-compatible Git to break down on it?
Right. The only solution i can see would have had to have been implemented already. And that would involved some headers being marked "pass through", some "marked throw away on cherry-pick" and some "choke horribly if you find this and dont know what it is".
And even with somethng like that one wonders if notes arent really a better alternative to user defined headers anyway?
Show 5 quoted lines
> On the other hand, allowing this preventively would apparently have > the immediate effect of alternative implementations users happily > starting to use it, and then to get to the data, people would demand > git-core support as well. _And_ so far everyone seems really really > fairly sure we don't want the headers and it's not likely to change.
Yes, right understood.
Show 5 quoted lines
> > P.S.: On the other hand, I think that change was probably just > misguided, not malicious. And I wouldn't be that hard on Dulwich, > it's an early-0.x software after all, it's allowed to crash and have > protocol issues. ;-)
Heh. I have no opinion on Dulwich. Didnt even know it existed until this mail.
Yves
-- perl -Mre=debug -e "/just|another|perl|hacker/"