Re: [PATCH] improve doc heading for git-bisect

From: Robert Anderson <rwa000@gmail.com>
Date: Jun 7, 2008, 16:06 UTC
Message-ID: <9af502e50806070906u63e52de4wa0bc4dced0c4d984@mail.gmail.com>
In-Reply-To: <m37id1y4zj.fsf@localhost.localdomain>

On Sat, Jun 7, 2008 at 2:22 AM, Jakub Narebski <jnareb@gmail.com> wrote:

Show 6 quoted lines

> rwa000@gmail.com (Robert Anderson) writes:
>
>> From 7af03a835b7311c501f2147e25f428642fc3acb7 Mon Sep 17 00:00:00 2001
>
> FYI this line is not necessary, and should be removed from
> git-format-patch output when pasting it to your MUA.

Err, then shouldn't it be removed from format-patch, rather than deleted manually every time format-patch is used?

Show 8 quoted lines

>> From: Robert W. Anderson <rwa000@gmail.com>
>> Date: Fri, 6 Jun 2008 23:53:37 -0700
>> Subject: [PATCH] improve doc heading for git-bisect
>
> FYI the above isn't strictly necessary: if you have 'From:' header set
> correctly you can simply set subject of email, and put in body the
> rest of commit message and patch only, without extra mail-like
> headers.

Then remove them from format-patch, IMO.

Show 13 quoted lines

>> Improve awkward heading in git-bisect documentation.
> [...]
>> -Avoiding to test a commit
>> -~~~~~~~~~~~~~~~~~~~~~~~~~
>> +Changing the revision to test
>> +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>
>>  If in a middle of bisect session, you know what the bisect suggested
>>  to try next is not a good one to test (e.g. the change the commit
>
> It is, I guess, better, but is it the best heading?  What we want to
> describe here is how to deal when bisect stops on commit which cannot
> be tested (e.g. project does not compile).

I disagree. The situation you want to use this is more general than that. Maybe you could test it, but doing so would be a waste of time because the commit is a trivial comment change. In general, this simply what you need to know when you want to change the revision under test.

Bob