Re: [PATCH] hooks: add sendemail-validate-series

From: Bagas Sanjaya <bagasdotme@gmail.com>
Date: Apr 1, 2023, 02:54 UTC
Message-ID: <9a0948e2-d030-ac89-a009-9247054f71f9@gmail.com>
In-Reply-To: <20230103231133.64050-1-robin@jarry.cc>

On 1/4/23 06:11, Robin Jarry wrote:

Show 14 quoted lines

> +sendemail-validate-series
> +~~~~~~~~~~~~~~~~~~~~~~~~~
> +
> +This hook is invoked by linkgit:git-send-email[1].  It allows performing
> +validation on a complete patch series at once, instead of patch by patch with
> +`sendemail-validate`.
> +
> +`sendemail-validate-series` takes no arguments, but for each e-mail to be sent
> +it receives on standard input a line of the format:
> +
> +  <patch-file> LF
> +
> +where `<patch-file>` is a name of a file that holds an e-mail to be sent,
> +

In most cases, the patch series is generated by git-format-patch(1). When the command is run, it will output:

``` $ git format-patch -o /tmp --cover-letter --base=<base-commit> <base-commit> /tmp/0000-cover-letter.patch /tmp/0001-<patch-subject>.patch /tmp/0002-<patch-subject>.patch /tmp/0003-<patch-subject>.patch ... ```

The output can be fed to the hook (as you write).

But I think the hook should also take patch file arguments, for the sake of completeness with sendemail-validate hook; that is:

``` sendemail-validate-series <patch file>... ```

Also, there should have a check that In-Reply-To must be the first patch in the given series or the cover letter (if there is one).

Anyway, rather than pinging by random people, I'd like to see [PATCH RESEND], rebased on latest git.git tree, ideally with Junio Cc'ed.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara