Re: [PATCH] git wrapper: also uses aliases to suggest mistyped commands
On 10 sep 2008, at 23:44, Junio C Hamano wrote:
Show 11 quoted lines
> Aliases should not hide the commands available elsewhere, and the
> actual
> execution codepath around ll.480-490 in git.c avoids getting fooled by
> misconfigured aliases, but you do not protect yourself from that
> kind of
> misconfiguration in this patch. You can have both "git-foo" command
> on
> your private $PATH and alias.foo in your configuration, and they
> will have
> the same levenshtein score. I suspect this will cause the same "foo"
> suggested twice when the user types "git fo" from the command line.
Yes, I didn't think of that.
> Here is a suggested fix-up on top of your patch to address these
> issues.
Looks good. Do you want me to resend the patch or will you squash it?
- Pieter