Re: Bug: git branch -D can be used to delete branch which is currently checked out - Part 2

From: Marcus Kida <marcus.kida@gmail.com>
Date: Mar 10, 2016, 18:30 UTC
Message-ID: <9EFA8642-FA02-4ADB-B37B-530E611C9C1F@gmail.com>
In-Reply-To: <alpine.DEB.2.20.1603101313220.4690@virtualbox>

Hi Johannes,

thank you for the feedback. I will fix this, test it and send a patch.

Cheers, Marcus

Show 21 quoted lines

> On 10 Mar 2016, at 11:15 PM, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> 
> Hi Marcus,
> 
>> On Thu, 10 Mar 2016, Marcus Kida wrote:
>> 
>> Proposed solution:
>> 
>> Use `strcasecmp`, `stricmp`, `strcmpi` here: https://github.com/git/git/blob/f02fbc4f9433937ee0463d0342d6d7d97e1f6f1e/builtin/branch.c#L218
>> 
>> Not sure if/which one of this will work on POSIX as well as MS too though.
> 
> This is not quite a solution (it is not a patch). And you *definitely*
> want to make the use of strcasecmp() contingent on ignore_case. You are
> not alone on this world, after all, and other people have case-sensitive
> filesystems. It's totally doable, of course.
> 
> So, do you feel up to the task?
> 
> Ciao,
> Johannes