git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] diff: report bogus input to -C/-M/-B

From
Kevin Ballard <kevin@sb.org>
Date
Oct 21, 2010, 20:37 UTC
Message-ID
<9E2CE0E8-40A4-4909-9317-B3DE9006474E@sb.org>
In-Reply-To
<20101021144947.GA18210@sigill.intra.peff.net>
On Oct 21, 2010, at 7:49 AM, Jeff King wrote:
Show 20 quoted lines
> We already detect invalid input to these functions, but we
> simply exit with an error code, never saying anything as
> simple as "your input was wrong". Let's fix that.
> 
> Before:
> 
>  $ git diff -CM
>  $ echo $?
>  128
> 
> After:
> 
>  $ git diff -CM
>  error: invalid argument to -C: M
>  $ echo $?
>  128
> 
> There should be no problems with having diff_opt_parse print
> to stderr, as there is already precedent in complaining
> about bogus --color and --output arguments.
Thank you. I've had a note to myself to fix this for the past month, and still haven't gotten around to it. Glad to see that procrastinating pays off! ;)
-Kevin Ballard
Previous: Jeff King
Message 4 of 4 in “diff: report bogus input to -C/-M/-B”
  1. diff: report bogus input to -C/-M/-BJeff King, Oct 21, 2010
  2. Jonathan NiederOct 21, 2010
  3. Jeff KingOct 21, 2010
  4. Kevin BallardOct 21, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.