Re: [PATCH] diff: report bogus input to -C/-M/-B
On Oct 21, 2010, at 7:49 AM, Jeff King wrote:
Show 20 quoted lines
> We already detect invalid input to these functions, but we
> simply exit with an error code, never saying anything as
> simple as "your input was wrong". Let's fix that.
>
> Before:
>
> $ git diff -CM
> $ echo $?
> 128
>
> After:
>
> $ git diff -CM
> error: invalid argument to -C: M
> $ echo $?
> 128
>
> There should be no problems with having diff_opt_parse print
> to stderr, as there is already precedent in complaining
> about bogus --color and --output arguments.
Thank you. I've had a note to myself to fix this for the past month, and still haven't gotten around to it. Glad to see that procrastinating pays off! ;)
-Kevin Ballard