Re: [BUG] t9801 and t9803 broken on next

From: Lars Schneider <larsxschneider@gmail.com>
Date: May 19, 2016, 17:32 UTC
Message-ID: <9CA2E5C1-ECAD-4C8C-A495-55041A1CC256@gmail.com>
In-Reply-To: <xmqq1t4ykmjj.fsf@gitster.mtv.corp.google.com>

Show 13 quoted lines

> On 19 May 2016, at 19:03, Junio C Hamano <gitster@pobox.com> wrote:
> 
> Lars Schneider <larsxschneider@gmail.com> writes:
> 
>> From my point of view little packs are no problem. I run fast-import on
>> a dedicated migration machine. After fast-import completion I run repack [1] 
>> before I upload the repo to its final location.
> 
> How do you determine that many little packs are not a problem to
> you, though?  Until they get repacked, they are where the
> fast-import will get existing objects from.  The more little packs
> you accumulate as you go, the more slow fast-import's access to them
> has to become.

True. But my particular use case is a one time operation for a given repository. Therefore I don't care how long it takes. The only important aspect is that the result is correct.

That being said, Peff's proposed fix looks correct to me but since I am no fast-import expert my opinion doesn't count too much.

- Lars