Re: [PATCH v1] git-p4: Add option to ignore empty commits

From: Lars Schneider <larsxschneider@gmail.com>
Date: Oct 28, 2015, 22:35 UTC
Message-ID: <9A4A2FFA-BCF0-46B6-A3A5-69D7F197FDA5@gmail.com>
In-Reply-To: <562E8FA2.9050507@diamand.org>

On 26 Oct 2015, at 21:40, Luke Diamand <luke@diamand.org> wrote:

Show 7 quoted lines

> On 24/10/15 19:08, Lars Schneider wrote:
>> 
>> On 21 Oct 2015, at 08:32, Luke Diamand <luke@diamand.org> wrote:
>> 
>>> On 19/10/15 19:43, larsxschneider@gmail.com wrote:
>>>> From: Lars Schneider <larsxschneider@gmail.com>
>>>>

-- snip --

Show 6 quoted lines

>> 
>>> Also, could you use python3 style print stmnts, print("whatever") ?
>> Sure. How do you prefer the formatting? Using "format" would be true Python 3 style I think:
>> print('Ignoring file outside of client spec: {}'.format(path))
> 
> Will that breaker older versions of python? There's a statement somewhere about how far back we support.

The "format" method requires Python 2.6 according to the Python docs: https://docs.python.org/2/library/functions.html#format

Luckily this is also the version we aim to support according to Documentation/CodingGuidelines

Thanks, Lars