git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v4 2/2] t4041: test SHA-256 submodule abbreviations

From
SGSrujith A Poojary via GitGitGadget <gitgitgadget@gmail.com>
Date
Nov 2, 2026, 19:40 UTC
Message-ID
<99a1234544840e63e6f3dcf3c6beae3ba02af84b.1793648430.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.2288.v4.git.1793648430.gitgitgadget@gmail.com>
From: Srujith A Poojary <poojarysrujith@gmail.com>

The expected abbreviation for a submodule commit depends on the repository's hash algorithm. Use test_oid_cache to provide the expected value for each algorithm and remove the SHA1 prerequisite so this test runs with both SHA-1 and SHA-256.

Signed-off-by: Srujith A Poojary <poojarysrujith@gmail.com>
---
 t/t4041-diff-submodule-option.sh | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/t/t4041-diff-submodule-option.sh b/t/t4041-diff-submodule-option.sh
index e80472af32..4539d6bba5 100755
--- a/t/t4041-diff-submodule-option.sh
+++ b/t/t4041-diff-submodule-option.sh
@@ -14,7 +14,11 @@ export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
 
 . ./test-lib.sh
 
-test_expect_success SHA1 'submodule commit abbreviation uses submodule object database' '
+test_expect_success 'submodule commit abbreviation uses submodule object database' '
+	test_oid_cache <<-EOF &&
+	submodule_commit1_abbrev sha1:0000000000e
+	submodule_commit1_abbrev sha256:24c81a5
+	EOF
 	test_when_finished "rm -rf collision-super" &&
 	git init -q collision-super &&
 	git init -q collision-super/sm1 &&
@@ -27,7 +31,8 @@ test_expect_success SHA1 'submodule commit abbreviation uses submodule object da
 	git -C collision-super update-index --add --cacheinfo 160000,"$commit1",sm1 &&
 	git -C collision-super commit -q -m "Add submodule" &&
 	git -C collision-super diff --submodule=log >actual &&
-	printf "Submodule sm1 0000000000e..%s:\n  > child\n" \
+	printf "Submodule sm1 %s..%s:\n  > child\n" \
+		"$(test_oid submodule_commit1_abbrev)" \
 		"$(git -C collision-super/sm1 rev-parse --short "$commit2")" >expected &&
 	test_cmp expected actual
 '
-- 
gitgitgadget
Previous: Srujith PoojaryNext: Junio C Hamano
Message 12 of 18 in “t4041: use submodule repository for commit abbreviations”
  1. [Outreachy PATCH] t4041: use submodule repository for commit abbreviationsSrujith A Poojary via GitGitGadget, Oct 31, 2026
  2. Okhuomon AjayiOct 31, 2026
  3. Srujith PoojaryOct 31, 2026
  4. Submodule: use the submodule repository to abbreviate commitsSrujith A Poojary via GitGitGadget, Oct 31, 2026
  5. Okhuomon AjayiOct 31, 2026
  6. Srujith PoojaryOct 31, 2026
  7. submodule: use the submodule repository to abbreviate commitsSrujith A Poojary via GitGitGadget, Oct 31, 2026
  8. Junio C HamanoNov 1, 2026
  9. 0/2 [Outreachy PATCH] t4041: use submodule repository for commit abbreviationsSrujith A Poojary via GitGitGadget, Nov 2, 2026
  10. 1/2 submodule: use the submodule repository to abbreviate commitsSrujith A Poojary via GitGitGadget, Nov 2, 2026
  11. Srujith PoojaryNov 2, 2026
  12. 2/2 t4041: test SHA-256 submodule abbreviationsSrujith A Poojary via GitGitGadget, Nov 2, 2026
  13. Junio C HamanoNov 3, 2026
  14. Srujith PoojaryNov 4, 2026
  15. Junio C HamanoNov 3, 2026
  16. submodule: use the submodule repository to abbreviate commitsSrujith A Poojary via GitGitGadget, Nov 4, 2026
  17. Junio C HamanoNov 4, 2026
  18. submodule: use the submodule repository to abbreviate commitsSrujith A Poojary via GitGitGadget, Nov 4, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.