Re: [PATCH 1/3] test-tool: add pack-deltas helper

From: Derrick Stolee <stolee@gmail.com>
Date: Apr 24, 2025, 20:06 UTC
Message-ID: <9999f7f2-759a-4721-a4d0-6d3bdeb17b25@gmail.com>
In-Reply-To: <xmqq34dxuz21.fsf@gitster.g>

On 4/24/2025 3:41 PM, Junio C Hamano wrote:

Show 21 quoted lines

> I needed this to make
> 
> $ SANITIZE=leak GIT_TEST_PASSING_SANITIZE_LEAK=true make
> $ cd t && sh t5309-pack-delta-cycles.sh
> 
> pass.
> --- >8 ------ >8 ------ >8 ---
> Subject: [PATCH] fixup! test-tool: add pack-deltas helper
> 
>  t/helper/test-pack-deltas.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/t/helper/test-pack-deltas.c b/t/helper/test-pack-deltas.c
> index db7d1c3cd1..c8e837ea06 100644
> --- a/t/helper/test-pack-deltas.c
> +++ b/t/helper/test-pack-deltas.c
> @@ -122,6 +122,7 @@ int cmd__pack_deltas(int argc, const char **argv)
>  			if (get_oid_hex(base_oid_str, &base_oid))
>  				die("invalid object: %s", base_oid_str);
>  		}
> +		string_list_clear(&items, 0);

Thanks. I'll make sure to apply it. My GGG PR validation was broken top-to-bottom due to other environmental issues so I had not seen this failure myself.

Thanks, -Stolee