Re: Git Rename Detection Bug

From

Philip Oakley <philipoakley@iee.email>

Date

Nov 15, 2023, 16:51 UTC

Message-ID

<990ab7d5-e29a-4766-b112-c8908a7ed196@iee.email>

In-Reply-To

<CABPp-BHEX+SyophEfgRqDbNdrAS3=bptt_cKzHLBSutnBAxexw@mail.gmail.com>

Hi Elijah,

On 11/11/2023 05:46, Elijah Newren wrote:

> * filename similarity is extraordinarily expensive compared to exact
> renames, and if not carefully handled, can sometimes rival the cost of
> file content similarity computations given our spanhash
> representations.

>    Exact renames are tasked with finding renames even
> if they are known to not be relevant, simply because exact renames can
> do so very quickly.  If we change that, we throw a monkey wrench in
> our performance handling elsewhere and have to rethink a number of
> other things.