git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git-gui.sh: support Tcl 8.4

From
Kyle J. McKay <mackyle@gmail.com>
Date
Jan 6, 2015, 10:41 UTC
Message-ID
<97e448e7908a1f959a7294e389553b5@74d39fa044aa309eaea14b9f57fe79c>

Tcl 8.5 introduced an extended vsatisfies syntax that is not supported by Tcl 8.4.

Since only Tcl 8.4 is required this presents a problem.

The extended syntax was used starting with Git 2.0.0 in commit b3f0c5c0 so that a major version change would still satisfy the condition.

However, what we really want is just a basic version compare, so use vcompare instead to restore compatibility with Tcl 8.4.

Signed-off-by: Kyle J. McKay
---
 git-gui/git-gui.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh
index b186329d..a1a23b56 100755
--- a/git-gui/git-gui.sh
+++ b/git-gui/git-gui.sh
@@ -1283,7 +1283,7 @@ load_config 0
 apply_config
 
 # v1.7.0 introduced --show-toplevel to return the canonical work-tree
-if {[package vsatisfies $_git_version 1.7.0-]} {
+if {[package vcompare $_git_version 1.7.0] >= 0} {
 	if { [is_Cygwin] } {
 		catch {set _gitworktree [exec cygpath --windows [git rev-parse --show-toplevel]]}
 	} else {
@@ -1539,7 +1539,7 @@ proc rescan_stage2 {fd after} {
 		close $fd
 	}
 
-	if {[package vsatisfies $::_git_version 1.6.3-]} {
+	if {[package vcompare $::_git_version 1.6.3] >= 0} {
 		set ls_others [list --exclude-standard]
 	} else {
 		set ls_others [list --exclude-per-directory=.gitignore]
-- 
2.1.4
Next: Junio C Hamano
Message 1 of 6 in “git-gui.sh: support Tcl 8.4”
  1. git-gui.sh: support Tcl 8.4Kyle J. McKay, Jan 6, 2015
  2. Junio C HamanoJan 6, 2015
  3. Kyle J. McKayJan 6, 2015
  4. Junio C HamanoJan 7, 2015
  5. Jens LehmannJan 7, 2015
  6. Pat ThoytsJan 13, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.