Re: [PATCH] make slash-rules more readable

From: Philip Oakley <philipoakley@talktalk.net>
Date: Jun 1, 2019, 09:33 UTC
Message-ID: <979f6497-5e26-4a93-c345-f61b31c736c6@talktalk.net>
In-Reply-To: <xmqqh89awprl.fsf@gitster-ct.c.googlers.com>

Hi Junio, On 31/05/2019 17:30, Junio C Hamano wrote:

Show 6 quoted lines

> I think the updated text is readable, except for one nit.
>
> Specifically, if you took my suggestion in an earlier review to
> explicitly say that leading slash is merely a workaround for a
> string without slash to anchor the pattern to the directory and
> it should be treated as if it does not exist otherwise, then ...

 From a user perspective, implementation issues shouldn't be part of the 
description unless absolutely essential.

Most user aren't aware of the implementation so don't grok/understand what the fuss is about and ignore it...

Show 5 quoted lines

>> + - The pattern `doc/frotz` and `/doc/frotz` have the same effect
>> +   in any `.gitignore` file. Both pattern contain a non-trailing
>> +   slash and thus match relative to the location of the
>> +   `.gitignore` file.
> ... this paragraph wouldn't have been necessary.

...leading to that user mistake having to be explained in numerous Q&A threads - Why can't we an explicit explanation of this common user mistake? Arguably the issue is the special trailing slash rule getting users confused..

-- Philip