Re: [PATCH v2] mergetools: add winmerge as a builtin tool

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: May 13, 2015, 08:10 UTC
Message-ID: <96de4a8c540c041733fd47a4cb1af782@www.dscho.org>
In-Reply-To: <1431482407-63642-1-git-send-email-davvid@gmail.com>

Hi David,

On 2015-05-13 04:00, David Aguilar wrote:

Show 6 quoted lines

> +	if test -n "$ProgramW6432" && test -x "$ProgramW6432/$winmerge_exe"
> +	then
> +		printf '%s' "$ProgramW6432/$winmerge_exe"
> +	elif test -n "$PROGRAMFILES" && test -x "$PROGRAMFILES/$winmerge_exe"
> +	then
> +		printf '%s' "$PROGRAMFILES/$winmerge_exe"

I am terribly sorry that I confused you... What I *meant* was to test in the following order: $PROGRAMFILES, $ProgramW6432, /c/Program Files, /c/Program Files (x86).

While I am already nitpicking, I would also like to throw out the idea to write that in a loop instead (a little bit more DRY):

for directory in "$PROGRAMFILES" "$ProgramW6432" '/c/Program Files' '/c/Program Files (x86)'
do
    test -n "$directory" &&
    test -x "$directory/$winmerge_exe" &&
    echo "$directory/$winmerge_exe" &&
    break
done

Ciao, Dscho