Re: [PATCH 01/13] Use 'Git' in help messages

From: Philip Oakley <philipoakley@iee.org>
Date: Feb 26, 2013, 22:38 UTC
Message-ID: <96C279DB1BA3478ABA712FF00EAB6C13@PhilipOakley>

From: "Philip Oakley" <philipoakley@iee.org>
Sent: Sunday, February 24, 2013 9:50 PM

Show 21 quoted lines

> From: "Junio C Hamano" <gitster@pobox.com>
> Sent: Sunday, February 24, 2013 8:59 AM
>> David Aguilar <davvid@gmail.com> writes:
>>
>>> This is referring to "git the command", not "git the system",
>>> so it should not be changed according to the rule that was
>>> applied when many "git" strings were changed to "Git".
>>
>> That sounds like a sensible objection.
>>
>
> I'd read the messages in the tone 'commands of the Git system', but I 
> can see that both views are equally plausible. Though the final 
> _("git: '%s' is not a Git command. See 'git --help'.") can't be 
> referring to a 'git-<cmd>', obviously ;-)
>
>>> There are scripts, etc. in the wild that parse this output.
>>> which is another reason we would not want to change this.
>>
>> Are there?  For what purpose?
>>

Just found that Git Gui checks for the version number (line 936)

    if {![regsub {^git version } $_git_version {} _git_version]} {

and then parses for the dot separated digits etc.

So looks like the version string change would be a problematic regression.

Given the change elsewhere of 'Usage:' to 'usage:' it looks like I should drop this patch.

Show 14 quoted lines

>> Especially when these are all _("l10n ready"), I find that somewhat
>> unlikely.
>>
>> The bash completion (in contrib/) does read from the command list
>> IIRC.  I do not think it relies on the messages, though.
>
> I was aware of that bash completion used 'git help -a' so I avoided 
> changing the response to that option. Initially I'd thought of making 
> '-a' provide both commands and guides but knew I'd need to ensure the 
> completion would still be sensible. I'd taken Juio's earlier advice to 
> keep '-a' unchanged and simply add the -g|--guides option as a 
> supplemental 'git help' response..
>
> Philip