Re: [PATCH v2] t5510: replace 'origin' with URL more carefully (was Re: Test Failure t5510,t5562 - was RE: [ANNOUNCE] Git v2.37.0-rc1)
- From
Johannes Sixt <j6t@kdbg.org>
- Date
- Jun 21, 2022, 05:28 UTC
- Message-ID
- <964a9ae5-35e7-8906-314a-f3c27624793d@kdbg.org>
- In-Reply-To
- <484a330e-0902-6e1b-8189-63c72dcea494@github.com>
Am 21.06.22 um 00:20 schrieb Derrick Stolee:
Show 8 quoted lines
> @@ -853,7 +853,9 @@ test_configured_prune_type () {
> then
> new_cmdline=$cmdline_setup
> else
> - new_cmdline=$(printf "%s" "$cmdline" | perl -pe 's[origin(?!/)]["'"$remote_url"'"]g')
> + new_cmdline=$(printf "%s" "$cmdline" |
> + sed -e "s~origin ~'$remote_url' ~g" \
> + -e "s~ origin~ '$remote_url'~g")I'm not sure if this is still an issue, but I recall that there are seds in the wild that do not grok an incomplete last line. Better make this `printf "%s\n" "$cmdline"` if `echo "$cmdline"` is not an option.
> fi > > if test "$fetch_prune_tags" = 'true' ||
-- Hannes