Re: [PATCH] mergetool: support absolute paths to tools by git config merge.<tool>path

From: Steffen Prohaska <prohaska@zib.de>
Date: Oct 9, 2007, 06:42 UTC
Message-ID: <9505CF7F-2024-48A8-88B0-0410DB2572B6@zib.de>
In-Reply-To: <20071008220025.GZ31659@planck.djpig.de>

On Oct 9, 2007, at 12:00 AM, Frank Lichtenheld wrote:

Show 11 quoted lines

> On Mon, Oct 08, 2007 at 11:22:40PM +0200, Steffen Prohaska wrote:
>> This commit adds a mechanism to provide absolute paths to the
>> commands called by 'git mergetool'. A path can be specified
>> in the configuation variable merge.<toolname>path.
>
> Why not merge.<toolname>.path?
>
> This would it make easy to introduce new variables of the form
> merge.<toolname>.<var> later if needed. I also think it is more
> consistent with names of existing configuration variables.
> (think branch.<name>.<var> or remote.<name>.<var>)

Looks more beautiful on the command line but a bit more complex in the config file. But I like the idea.

Maybe mergetool.<tool>.path is even a better choice? It clearly indicate the relationship with mergetool. We could explain:

'The variable merge.tool = <tool> refers to a tool that can be further specified in mergetool.<tool>.path.'

	Steffen