git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/3] t6429: update comment to mention correct tool

From
Elijah Newren via GitGitGadget <gitgitgadget@gmail.com>
Date
Nov 3, 2025, 18:01 UTC
Message-ID
<950236f0f812197e260159a688fc6f6fa61046c7.1762192908.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.1992.git.1762192908.gitgitgadget@gmail.com>
From: Elijah Newren <newren@gmail.com>

A comment at the top of t6429 mentions why the test doesn't exercise git rebase or git cherry-pick. However, it claims that it uses `test-tool fast-rebase`. That was true when the comment was written, but commit f920b0289ba3 (replay: introduce new builtin, 2023-11-24) changed it to use git replay without updating this comment.

We could potentially just strike this second comment, since git replay is a bonified built-in, but perhaps the explanation about why it focuses on git replay is still useful. Update the comment to make it accurate again.

Signed-off-by: Elijah Newren <newren@gmail.com>
---
 t/t6429-merge-sequence-rename-caching.sh | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/t/t6429-merge-sequence-rename-caching.sh b/t/t6429-merge-sequence-rename-caching.sh
index 0f39ed0d08..dcb734b10b 100755
--- a/t/t6429-merge-sequence-rename-caching.sh
+++ b/t/t6429-merge-sequence-rename-caching.sh
@@ -11,14 +11,13 @@ test_description="remember regular & dir renames in sequence of merges"
 #         sure that we are triggering rename caching rather than rename
 #         bypassing.
 #
-# NOTE 2: this testfile uses 'test-tool fast-rebase' instead of either
-#         cherry-pick or rebase.  sequencer.c is only superficially
-#         integrated with merge-ort; it calls merge_switch_to_result()
-#         after EACH merge, which updates the index and working copy AND
-#         throws away the cached results (because merge_switch_to_result()
-#         is only supposed to be called at the end of the sequence).
-#         Integrating them more deeply is a big task, so for now the tests
-#         use 'test-tool fast-rebase'.
+# NOTE 2: this testfile uses replay instead of either cherry-pick or rebase.
+#         sequencer.c is only superficially integrated with merge-ort; it
+#         calls merge_switch_to_result() after EACH merge, which updates the
+#         index and working copy AND throws away the cached results (because
+#         merge_switch_to_result() is only supposed to be called at the end
+#         of the sequence).  Integrating them more deeply is a big task, so
+#         for now the tests use 'git replay'.
 #
 
 
-- 
gitgitgadget
Previous: Elijah Newren via GitGitGadgetNext: Kristoffer Haugsbakk
Message 4 of 9 in “Fix another crazy rename assertion”
  1. 0/3 Fix another crazy rename assertionElijah Newren via GitGitGadget, Nov 3, 2025
  2. 2/3 merge-ort: remove debugging crudElijah Newren via GitGitGadget, Nov 3, 2025
  3. 3/3 merge-ort: fix failing merges in special corner caseElijah Newren via GitGitGadget, Nov 3, 2025
  4. 1/3 t6429: update comment to mention correct toolElijah Newren via GitGitGadget, Nov 3, 2025
  5. Kristoffer HaugsbakkNov 7, 2025
  6. Elijah NewrenNov 7, 2025
  7. Junio C HamanoNov 17, 2025
  8. Elijah NewrenNov 17, 2025
  9. Junio C HamanoNov 17, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.