Re: [PATCH v2 04/13] config: format int64s gently
- From
Derrick Stolee <stolee@gmail.com>
- Date
- Feb 23, 2026, 03:41 UTC
- Message-ID
- <94ee4b78-48f9-4e2c-aee5-ced1dc9a12fd@gmail.com>
- In-Reply-To
- <aZQvP21anXXZWcMh@pks.im>
On 2/17/26 4:05 AM, Patrick Steinhardt wrote:
Show 14 quoted lines
> On Fri, Feb 13, 2026 at 11:55:09PM +0000, Derrick Stolee via GitGitGadget wrote:
>> diff --git a/builtin/config.c b/builtin/config.c
>> index 4c4c791883..d259a91d53 100644
>> --- a/builtin/config.c
>> +++ b/builtin/config.c
>> @@ -237,6 +237,25 @@ struct strbuf_list {
>> int alloc;
>> };
>>
>> +static int format_config_int64(struct strbuf *buf,
>> + const char *key_,
>> + const char *value_,
>
> Why do we have the trailing underscores here?This is all to match the existing names from format_config(). This may help to recognize moved lines by keeping the variable names the same. Definitely not my preference to use this name format, but I thought it fitting to avoid a rename of all variables.
Thanks, -Stolee