Re: [PATCH 1/2] format-patch: fix dashdash usage

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Nov 28, 2009, 11:18 UTC
Message-ID: <94a0d4530911280318nd6ea6d4s7ee159fe173a3f2f@mail.gmail.com>
In-Reply-To: <7vhbsg25sb.fsf@alter.siamese.dyndns.org>

On Fri, Nov 27, 2009 at 2:03 AM, Junio C Hamano <gitster@pobox.com> wrote:

>  (0) take your patch with an updated message (eh, that is not "next step"
>     but the "first step");

I guess it depends of what is the "fist step". To me the "first step" is realizing there's a problem. First patch submission is already many steps afterwards.

But sure, I'll do this next step :)

>  (1) make --full-diff implicit and default of format-patch (--no-full-diff
>     could be supported _if_ somebody can argue successfully why limiting
>     the diff is also a useful thing to do); and

I started writing this patch but it turns out there's no --no-full-diff.

>  (2) document clearly that format-patch takes optional pathspecs, and in
>     what situation they are useful.

I guess this would have to be done in multiple places so it might take me some time.

Cheers.

-- 
Felipe Contreras