git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git diff does not precompose unicode file paths (OS X)

From
Alexander Rinass <alex@fournova.com>
Date
Apr 4, 2016, 20:43 UTC
Message-ID
<9490B637-D3DD-45CC-B2D7-B471AD6B5956@fournova.com>
In-Reply-To
<56E7A191.7070302@web.de>
Show 15 quoted lines
> On 15 Mar 2016, at 06:45, Torsten Bögershausen <tboegi@web.de> wrote:
> 
> >I created a test case but git diff exits with 0 if it does not recognize the file >path so the test case always succeeds. Can you give me a hint or one >example test case?
> 
> The most clean (?) is to compare "git diff" NFC and git diff NFD, they should give the same result:
> for "git diff" something like this would do:
> +
> +# This will test git diff
> +test_expect_success "git diff f.Adiar" '
> +       echo "Modified" >f.$Adiarnfd &&
> +       git diff f.$Adiarnfd >expect &&
> +       git diff f.$Adiarnfc >actual &&
> +       git checkout f.$Adiarnfd &&
> +       test_cmp expect actual
> +’
Thank you!

I had to tweak it a little but it now reproduces the issue and confirms the fix for diff, diff-index, diff-files and diff-tree.

I have just sent in the full patch.
Previous: Torsten Bögershausen
Message 11 of 11 in “git diff does not precompose unicode file paths (OS X)”
  1. Alexander RinassMar 4, 2016
  2. Torsten BögershausenMar 4, 2016
  3. Alexander RinassMar 4, 2016
  4. Junio C HamanoMar 4, 2016
  5. Ramsay JonesMar 4, 2016
  6. Alexander RinassMar 7, 2016
  7. Torsten BögershausenMar 7, 2016
  8. Torsten BögershausenMar 8, 2016
  9. Alexander RinassMar 14, 2016
  10. Torsten BögershausenMar 15, 2016
  11. Alexander RinassApr 4, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.