Re: git diff does not precompose unicode file paths (OS X)
- From
Alexander Rinass <alex@fournova.com>
- Date
- Apr 4, 2016, 20:43 UTC
- Message-ID
- <9490B637-D3DD-45CC-B2D7-B471AD6B5956@fournova.com>
- In-Reply-To
- <56E7A191.7070302@web.de>
Show 15 quoted lines
> On 15 Mar 2016, at 06:45, Torsten Bögershausen <tboegi@web.de> wrote: > > >I created a test case but git diff exits with 0 if it does not recognize the file >path so the test case always succeeds. Can you give me a hint or one >example test case? > > The most clean (?) is to compare "git diff" NFC and git diff NFD, they should give the same result: > for "git diff" something like this would do: > + > +# This will test git diff > +test_expect_success "git diff f.Adiar" ' > + echo "Modified" >f.$Adiarnfd && > + git diff f.$Adiarnfd >expect && > + git diff f.$Adiarnfc >actual && > + git checkout f.$Adiarnfd && > + test_cmp expect actual > +’
Thank you!
I had to tweak it a little but it now reproduces the issue and confirms the fix for diff, diff-index, diff-files and diff-tree.
I have just sent in the full patch.