git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/3] git-p4: Fix an obvious typo

From
TTTommy Thorn <tommy-git@thorn.ws>
Date
Feb 3, 2008, 09:21 UTC
Message-ID
<9439626e72a267ff29cb6eaa1c733ec4641341d9.1202029604.git.tommy-git@thorn.ws>
The regexp "$," can't match anything. Clearly not intended.
This was introduced in ce6f33c8 which is quite a while ago.
Signed-off-by: Tommy Thorn <tommy-git@thorn.ws>
---
 contrib/fast-import/git-p4 |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4
index c80a6da..553e237 100755
--- a/contrib/fast-import/git-p4
+++ b/contrib/fast-import/git-p4
@@ -1670,7 +1670,7 @@ class P4Clone(P4Sync):
         depotPath = args[0]
         depotDir = re.sub("(@[^@]*)$", "", depotPath)
         depotDir = re.sub("(#[^#]*)$", "", depotDir)
-        depotDir = re.sub(r"\.\.\.$,", "", depotDir)
+        depotDir = re.sub(r"\.\.\.$", "", depotDir)
         depotDir = re.sub(r"/$", "", depotDir)
         return os.path.split(depotDir)[1]
 
-- 
1.5.4.rc5.17.g22b645
Next: Tommy Thorn
Message 1 of 5 in “git-p4: Fix an obvious typo”
  1. 1/3 git-p4: Fix an obvious typoTommy Thorn, Feb 3, 2008
  2. 2/3 git-p4: support exclude pathsTommy Thorn, Feb 3, 2008
  3. 3/3 git-p4: no longer keep all file contents while cloningTommy Thorn, Feb 3, 2008
  4. Simon HausmannFeb 3, 2008
  5. Tommy ThornFeb 3, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.