Re: [PATCH] commit-graph: fix some "plain integer as NULL pointer" warnings

From: René Scharfe <l.s.r@web.de>
Date: Feb 24, 2018, 05:42 UTC
Message-ID: <93d2329a-1963-dca8-2f9e-ba225ead9d0b@web.de>
In-Reply-To: <e0bc5fe0-3b32-bebf-11cd-e335a8cf4e1c@ramsayjones.plus.com>

Am 24.02.2018 um 03:24 schrieb Ramsay Jones:

Show 11 quoted lines

> diff --git a/commit-graph.c b/commit-graph.c
> index fc5ee7e99..c2f443436 100644
> --- a/commit-graph.c
> +++ b/commit-graph.c
> @@ -45,7 +45,7 @@ char *get_graph_latest_filename(const char *obj_dir)
>   {
>   	struct strbuf fname = STRBUF_INIT;
>   	strbuf_addf(&fname, "%s/info/graph-latest", obj_dir);
> -	return strbuf_detach(&fname, 0);
> +	return strbuf_detach(&fname, NULL);
>   }

You could also replace that function body with:

	return xstrfmt("%s/info/graph-latest", obj_dir);

René