Re: [PATCH 1/9] extension.partialclone: introduce partial clone extension
On 11/8/2017 4:51 PM, Jonathan Tan wrote:
Show 21 quoted lines
> On Wed, 8 Nov 2017 15:32:21 -0500
> Jeff Hostetler <git@jeffhostetler.com> wrote:
>
>> Thanks Jonathan.
>>
>> I moved my version of part 2 on top of yesterday's part 1.
>> There are a few changes between my version and yours. Could
>> you take a quick look at them and see if they make sense?
>> (I'll spare the mailing list another patch series until after
>> I attend to the feed back on part 1.)
>>
>> https://github.com/jeffhostetler/git/commits/core/pc3_p2
>
> Thanks - the differences are quite minor, and they generally make sense.
> The main one is that finish_object() in builtin/rev-list.c now returns
> int instead of void, but that makes sense.
>
> Other than that:
>
> - I think you accidentally squashed the rev-list commit into
> "sha1_file: support lazily fetching missing objects".
Show 6 quoted lines
> - The documentation for --exclude-promisor-objects in
> git-pack-objects.txt should be "Omit objects that are known to be in
> the promisor remote". (This option has the purpose of operating only
> on locally created objects, so that when we repack, we still maintain
> a distinction between locally created objects [without .promisor] and
> objects from the promisor remote [with .promisor].)
> - The transport options in gitremote-helpers.txt could have the same
> documentation as in transport.h.