Re: [PATCH] stash: don't translate literal commands

From: Derrick Stolee <stolee@gmail.com>
Date: May 17, 2021, 16:48 UTC
Message-ID: <91d3d4e7-a04f-3fc4-a97b-90af02b20ed5@gmail.com>
In-Reply-To: <20210516215704.32440-1-alexhenrie24@gmail.com>

On 5/16/2021 5:57 PM, Alex Henrie wrote:

Show 15 quoted lines

> Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
> ---
>  builtin/stash.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/builtin/stash.c b/builtin/stash.c
> index d68ed784d2..075bcf6ee5 100644
> --- a/builtin/stash.c
> +++ b/builtin/stash.c
> @@ -26,7 +26,7 @@ static const char * const git_stash_usage[] = {
>  	N_("git stash drop [-q|--quiet] [<stash>]"),
>  	N_("git stash ( pop | apply ) [--index] [-q|--quiet] [<stash>]"),
>  	N_("git stash branch <branchname> [<stash>]"),
> -	N_("git stash clear"),
> +	"git stash clear",

I immediately saw the commands above and wondered why you are not removing them from being translated. My guess is that the "<stash>" strings are the bits that are interesting to translate. Perhaps add some description in your commit message as to why you are drawing the line here?

Show 5 quoted lines

>  static const char * const git_stash_clear_usage[] = {
> -	N_("git stash clear"),
> +	"git stash clear",
>  	NULL
>  };

Are there other instances in builtin/*.c? If not, then it would be nice to say so. Otherwise, it would be good to fix them, while you are here.

Thanks, -Stolee