[PATCH v4 2/2] index: raise a bug if the index is materialised more than once

From: Anh Le via GitGitGadget <gitgitgadget@gmail.com>
Date: Nov 3, 2022, 23:05 UTC
Message-ID: <91ad797330731e48907767d13213c8d8f899d996.1667516701.git.gitgitgadget@gmail.com>
In-Reply-To: <pull.1368.v4.git.git.1667516701.gitgitgadget@gmail.com>

From: Anh Le <anh@canva.com>

If clear_skip_worktree_from_present_files() encounter a sparse directory, it fully materialise the index which should expand any sparse directories and start going through each entries again. If this happens more than once, raise it with a BUG.

Signed-off-by: Anh Le <anh@canva.com>
---
 sparse-index.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sparse-index.c b/sparse-index.c
index 8713a15611d..8c269dab803 100644
--- a/sparse-index.c
+++ b/sparse-index.c
@@ -510,6 +510,8 @@ restart:
 			path_count[restarted]++;
 			if (path_found(ce->name, &last_dirname, &dir_len, &dir_found)) {
 				if (S_ISSPARSEDIR(ce->ce_mode)) {
+					if (restarted)
+						BUG("ensure-full-index did not fully flatten?");
 					ensure_full_index(istate);
 					restarted = 1;
 					goto restart;

-- 
gitgitgadget