Re: git send-email Connection Closed

From: Stefan Agner <stefan@agner.ch>
Date: Jul 24, 2015, 12:59 UTC
Message-ID: <91a8d8eb8767d29a4ed0a96d7a633c37@agner.ch>
In-Reply-To: <CAFow2F9ZFNcBdoc7YTCeGT_PA-UvMyfcKWE4K4ufGMyFXJd5Uw@mail.gmail.com>

Hi Juston,

On 2015-07-15 07:11, Juston Li wrote:

Show 13 quoted lines

> Recently, I have had trouble using git send-email to send a patchset.
> After the confirmation to send the email I get the following:
> Send this email? ([y]es|[n]o|[q]uit|[a]ll): y
> [Net::SMTP::SSL] Connection closed at /usr/lib/git-core/git-send-email
> line 1320.
> fatal: 'send-email' appears to be a git command, but we were not
> able to execute it. Maybe git-send-email is broken?
> 
> This message first appeared when I tried to send a 19 commit patchset
> via 'git send-email HEAD~19'. It also fails when I try to format-patch
> and send the patchset separately via 'git send-email 0001...'
> Oddly enough, it works when I send anything other than 19 commits
> for example 'git send-email HEAD~1' or 'git send-email HEAD~20'

Just got a similar message here, without the fatal part, just: [Net::SMTP::SSL] Connection closed at /usr/lib/git-core/git-send-email line 1320.

It seems that only one patch is causing the problem (in my case the first after the cover letter). I use TLS too and send it over a postfix SMTP server I maintain myself. The postfix log shows this:

postfix/smtpd[8535]: lost connection after DATA (16357 bytes) from unknown[x.y.z.z] postfix/smtpd[8535]: disconnect from unknown[x.y.z.z]

So it seems that the client side disconnects?

I rerun the command with --smtp-debug=1

...
Net::SMTP::SSL=GLOB(0x1fb3558)>>> +MODULE_LICENSE("GPL");
Net::SMTP::SSL=GLOB(0x1fb3558)>>> -- 
Net::SMTP::SSL=GLOB(0x1fb3558)>>> 2.4.5
Net::SMTP::SSL: Net::Cmd::datasend(): unexpected EOF on command channel:
 at /usr/lib/git-core/git-send-email line 1320.
[Net::SMTP::SSL] Connection closed at /usr/lib/git-core/git-send-email
line 1320.

It seems to me that there is a size limit, after cutting down the patch
to ~16K, sending started to work. I cut it twice, once by removing lines
from the head and once from the bottom, in both cases at the size of
around 16K I could send the patch.

Show 15 quoted lines

> I thought it was something with the gmail servers but I was able to send
> the patchset by downgrading a couple perl packages
> warning: downgrading package perl (5.22.0-1 => 5.20.2-1)
> warning: downgrading package perl-net-ssleay (1.68-2 => 1.67-1)
> 
> Note perl-net-ssleay depends on perl 5.22 so I can't isolate which
> package but I can consistently get the failure with the newest packges
> and it works fine with the downgraded packages.
> 
> Running Arch Linux
> git 2.4.5
> perl 5.22.0
> perl-authen-sasl 2.16
> perl-mime-tools 5.505
> perl-net-smtp-ssl 1.03

Same versions here, unfortunately I can't downgrade because I recently cleared my package cache :-(

-- Stefan