Re: [PATCH v4 0/4] cache parent project's gitdir in submodules

From

Derrick Stolee <stolee@gmail.com>

Date

Oct 25, 2021, 16:19 UTC

Message-ID

<911ab2c1-8a11-d9d0-4b28-fc801112f6da@gmail.com>

In-Reply-To

<20211014203416.2802639-1-emilyshaffer@google.com>

On 10/14/2021 4:34 PM, Emily Shaffer wrote:

> Since v3, a pretty major change: the semantics of
> submodule.superprojectGitDir has changed, to point from the submodule's
> gitdir to the superproject's gitdir (in v3 and earlier, we kept a path
> from the submodule's *worktree* to the superproject's gitdir instead).
> This cleans up some of the confusions about the behavior when a
> submodule worktree moves around in the superproject's tree, or in a
> future when we support submodules having multiple worktrees.

I like the new design!
 

> I also tried to simplify the tests to use 'test-tool path-utils
> relative_path' everywhere - I think that makes them much more clear for
> a test reader, but if you're reviewing and it isn't obvious what we're
> testing for, please speak up.

I found these changes to be well motivated.

> I think this is pretty mature and there was a lot of general agreement
> that the gitdir->gitdir association was the way to go, so please be
> brutal and look for nits, leaks, etc. this round ;)