Re: What's cooking in git.git (Nov 2009, #02; Sun, 08)

From: Tarmigan <tarmigan+git@gmail.com>
Date: Nov 9, 2009, 08:08 UTC
Message-ID: <905315640911090008h34b55a37q439d02de37127039@mail.gmail.com>
In-Reply-To: <7vzl6wz36r.fsf@alter.siamese.dyndns.org>

On Sun, Nov 8, 2009 at 9:18 PM, Junio C Hamano <gitster@pobox.com> wrote:

> * sp/smart-http (2009-11-04) 30 commits
>  + test smart http fetch and push

I am trying to test smart http, and have had to set DEFAULT_HTTPD_PATH='/usr/sbin/httpd' DEFAULT_HTTPD_MODULE_PATH='/usr/lib64/httpd/modules' on Centos. Perhaps this failing test is just a difference in the default Apache and curl configurations.

Testing with 7f640b7 ("http-backend: Test configuration options") gives me errors with the third test in t5551-http-fetch. I don't really know the point of the sed lines, but I am attaching my "err" file in case some of the problem is with the CR/LF stuff.

Thanks, Tarmigan

* expecting success:
	GIT_CURL_VERBOSE=1 git clone --quiet $HTTPD_URL/smart/repo.git clone 2>err &&
	test_cmp file clone/file &&
	tr '\015' Q <err |
	sed -e "
		s/Q\$//
		/^[*] /d

		/^[^><]/{
			s/^/> /
		}

		/^> User-Agent: /d
		/^> Host: /d
		s/^> Content-Length: .*/> Content-Length: xxx/

		/^< Server: /d
		/^< Expires: /d
		/^< Date: /d
		/^< Content-Length: /d
		/^< Transfer-Encoding: /d
	" >act &&
	test_cmp exp act

--- exp 2009-11-09 07:33:19.000000000 +0000 +++ act 2009-11-09 07:33:19.000000000 +0000

@@ -6,15 +6,16 @@
 < Pragma: no-cache
 < Cache-Control: no-cache, max-age=0, must-revalidate
 < Content-Type: application/x-git-upload-pack-advertisement
-<
 > POST /smart/repo.git/git-upload-pack HTTP/1.1
+> Accept: */*
 > Accept-Encoding: deflate, gzip
 > Content-Type: application/x-git-upload-pack-request
 > Accept: application/x-git-upload-pack-response
 > Content-Length: xxx

+> 0073want 1937bb05802e1973cc2e437c13e9f1845941b785
multi_ack_detailed side-band-64k thin-pack no-progress ofs-delta
+> 00000009done
 < HTTP/1.1 200 OK
 < Pragma: no-cache
 < Cache-Control: no-cache, max-age=0, must-revalidate
 < Content-Type: application/x-git-upload-pack-result
-<
* FAIL 3: clone http repository
	
		GIT_CURL_VERBOSE=1 git clone --quiet $HTTPD_URL/smart/repo.git clone 2>err &&
		test_cmp file clone/file &&
		tr '\015' Q <err |
		sed -e "
			s/Q\$//
			/^[*] /d
	
			/^[^><]/{
				s/^/> /
			}
	
			/^> User-Agent: /d
			/^> Host: /d
			s/^> Content-Length: .*/> Content-Length: xxx/
	
			/^< Server: /d
			/^< Expires: /d
			/^< Date: /d
			/^< Content-Length: /d
			/^< Transfer-Encoding: /d
		" >act &&
		test_cmp exp act