Re: sharedrepository=group not working

From: Jamie Zawinski <jwz@jwz.org>
Date: Dec 4, 2018, 05:24 UTC
Message-ID: <903E1F42-3911-471D-B754-7592A5FD2CC7@jwz.org>
In-Reply-To: <20181204045051.GA23351@sigill.intra.peff.net>

On Dec 3, 2018, at 8:50 PM, Jeff King <peff@peff.net> wrote:

Show 7 quoted lines

> 
> I don't suppose this is leaving those incoming-* directories sitting
> around so we can inspect their permissions (it's suppose to clean them
> up, so I doubt it). If you're up for it, it might be interesting to
> patch Git to inspect the umask and "ls -l" the objects/ directory at the
> problematic moment. The interesting point is when we call into
> tmp-objdir.c:setup_tmp_objdir().

The problem was that Apache was setting my umask to 113! With that:

+ ls -ldF ./objects/incoming-w7agmb/pack objects/incoming-w7agmb
ls: cannot access ./objects/incoming-w7agmb/pack: Permission denied
drw---S--- 2 apache cvs 4096 Dec  3 21:14 objects/incoming-w7agmb/
error: remote unpack failed: unable to create temporary object directory

With 002 it succeeds:

+ ls -ldF ./objects/incoming-IbGS6h/pack objects/incoming-IbGS6h
drwx--S--- 3 apache cvs 4096 Dec  3 21:19 objects/incoming-IbGS6h/
drwxrwsr-x 2 apache cvs 4096 Dec  3 21:19 ./objects/incoming-IbGS6h/pack/

So I fixed my umask and got it working, but maybe a test for "your umask is dumb" is worthwhile.

Thanks for your help!

-- Jamie Zawinski https://www.jwz.org/ https://www.dnalounge.com/