git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/6] t/lib-submodule-update: remove outdated test description

From
Philippe Blain via GitGitGadget <gitgitgadget@gmail.com>
Date
Feb 17, 2020, 04:53 UTC
Message-ID
<9004c95a72847615ded3d50779b80b77004df736.1581915186.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.555.git.1581915186.gitgitgadget@gmail.com>
From: Philippe Blain <levraiphilippeblain@gmail.com>

The commands in the unpack_trees machinery (checkout, reset, read-tree) were fixed in 218c883783 (submodule: properly recurse for read-tree and checkout, 2017-05-02) to correctly update nested submodules when called with the `--recurse-submodules` flag.

However, a comment in t/lib-submodule-update.sh mentions that this use case still doesn't work.

Remove this outdated comment.
Signed-off-by: Philippe Blain <levraiphilippeblain@gmail.com>
---
 t/lib-submodule-update.sh | 1 -
 1 file changed, 1 deletion(-)
diff --git a/t/lib-submodule-update.sh b/t/lib-submodule-update.sh
index 1dd17fc03e1..5f9eb682f6a 100755
--- a/t/lib-submodule-update.sh
+++ b/t/lib-submodule-update.sh
@@ -908,7 +908,6 @@ test_submodule_switch_recursing_with_args () {
 		)
 	'
 
-	# recursing deeper than one level doesn't work yet.
 	test_expect_success "$command: modified submodule updates submodule recursively" '
 		prolog &&
 		reset_work_tree_to_interested add_nested_sub &&
-- 
gitgitgadget
Previous: Philippe Blain via GitGitGadgetNext: Philippe Blain via GitGitGadget
Message 2 of 9 in “unpack-trees: fix '--recurse-submodules' when switching from no submodules to nested submodules”
  1. 0/6 unpack-trees: fix '--recurse-submodules' when switching from no submodules to nested submodulesPhilippe Blain via GitGitGadget, Feb 17, 2020
  2. 2/6 t/lib-submodule-update: remove outdated test descriptionPhilippe Blain via GitGitGadget, Feb 17, 2020
  3. 4/6 unpack-trees: remove outdated description for verify_clean_submodulePhilippe Blain via GitGitGadget, Feb 17, 2020
  4. 5/6 unpack-trees: check for missing submodule directory in merged_entryPhilippe Blain via GitGitGadget, Feb 17, 2020
  5. Junio C HamanoFeb 19, 2020
  6. 1/6 t7112: remove mention of KNOWN_FAILURE_SUBMODULE_RECURSIVE_NESTEDPhilippe Blain via GitGitGadget, Feb 17, 2020
  7. Junio C HamanoFeb 19, 2020
  8. 3/6 t/lib-submodule-update: move a test to the right sectionPhilippe Blain via GitGitGadget, Feb 17, 2020
  9. 6/6 t/lib-submodule-update: add test removing nested submodulesPhilippe Blain via GitGitGadget, Feb 17, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.