Re: [PATCH] gitweb: Show project's git URL on summary page

From: Jakub Narebski <jnareb@gmail.com>
Date: Aug 15, 2006, 19:32 UTC
Message-ID: <8fe92b430608151232y3f0ecd8ei435337709557162e@mail.gmail.com>
In-Reply-To: <Pine.LNX.4.63.0608151139280.29668@chino.corp.google.com>

On 8/15/06, David Rientjes <rientjes@google.com> wrote:

> On Tue, 15 Aug 2006, Jakub Narebski wrote:

Show 18 quoted lines

> > +     my $is_first_url = 1;
> > +     foreach my $git_base_url (@git_base_url_list) {
> > +             next unless $git_base_url; # skip empty/zerolength URLs
> > +             print "<tr><td>";
> > +             if ($is_first_url) {
> > +                     print "URL";
> > +                     $is_first_url = 0;
> > +             }
> > +             print "</td><td>$git_base_url/$project</td></tr>\n";
> > +     }
>
> Isn't it faster to do this (over 1.4.2):
> +       my $url_tag = "URL";
> +       foreach my $git_base_url (@git_base_url_list) {
> +               next unless $git_base_url;
> +               print "<tr><td>$url_tag</td><td>$git_base_url/$project</td></tr>\n";
> +               $url_tag = "";
> +       }

Yes, it is undobtedly better.

Acked-by: Jakub Narebski <jnareb@gmail.com>

-- 
Jakub Narebski