git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 4/8] t5503: fix overspecification of trace expectation

From
JTJonathan Tan <jonathantanmy@google.com>
Date
Feb 25, 2019, 21:54 UTC
Message-ID
<8f510c5c78dd5152307e30f8115188ad689b8c57.1551131153.git.jonathantanmy@google.com>
In-Reply-To
<cover.1551131153.git.jonathantanmy@google.com>

In order to extract the wants from a trace, a loop in t5503 currently breaks if "0000" is found. This works for protocol v0 and v1, but not v2. Instead, teach t5503 to look specifically for the "want" string, which is compatible with all protocols.

Signed-off-by: Jonathan Tan <jonathantanmy@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 t/t5503-tagfollow.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t5503-tagfollow.sh b/t/t5503-tagfollow.sh
index 4ca48f0276..6041a4dd32 100755
--- a/t/t5503-tagfollow.sh
+++ b/t/t5503-tagfollow.sh
@@ -47,7 +47,7 @@ get_needs () {
 	test -s "$1" &&
 	perl -alne '
 		next unless $F[1] eq "upload-pack<";
-		last if $F[2] eq "0000";
+		next unless $F[2] eq "want";
 		print $F[2], " ", $F[3];
 	' "$1"
 }
-- 
2.19.0.271.gfe8321ec05.dirty
Previous: Jonathan Tan
Message 9 of 9 in “GIT_TEST_PROTOCOL_VERSION, this time on master”
  1. 0/8 GIT_TEST_PROTOCOL_VERSION, this time on masterJonathan Tan, Feb 25, 2019
  2. 1/8 tests: define GIT_TEST_PROTOCOL_VERSIONJonathan Tan, Feb 25, 2019
  3. 2/8 t5601: check ssh command only with protocol v0Jonathan Tan, Feb 25, 2019
  4. 3/8 tests: always test fetch of unreachable with v0Jonathan Tan, Feb 25, 2019
  5. 5/8 t5512: compensate for v0 only sending HEAD symrefsJonathan Tan, Feb 25, 2019
  6. 6/8 t5700: only run with protocol version 1Jonathan Tan, Feb 25, 2019
  7. 7/8 tests: fix protocol version for overspecificationsJonathan Tan, Feb 25, 2019
  8. 8/8 t5552: compensate for v2 filtering ref adv.Jonathan Tan, Feb 25, 2019
  9. 4/8 t5503: fix overspecification of trace expectationJonathan Tan, Feb 25, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.