git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t6137-*.sh: fix test failure on cygwin

From
Ramsay Jones <ramsay@ramsayjones.plus.com>
Date
Aug 9, 2025, 11:50 UTC
Message-ID
<8f3e6afc-4dce-420e-a6a4-d54b0409aa2f@ramsayjones.plus.com>
In-Reply-To
<xmqq8qjth7um.fsf@gitster.g>
On 08/08/2025 21:33, Junio C Hamano wrote:
Show 26 quoted lines
> Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
> 
>> [Hmm, I have just noticed that the 'skip_all' message could drop the
>> redundant 'skipping: ' at the beginning - oh well! ;) ]
> 
> Yeah, I see skip_all="# SKIP $skip_all" in test-lib.sh
> 
> Let me squash the following in, to further match the message we give
> when the test environment fails a test prerequisite.
> 
>  t/t6137-pathspec-wildcards-literal.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git c/t/t6137-pathspec-wildcards-literal.sh w/t/t6137-pathspec-wildcards-literal.sh
> index 17a03085ef..e582378181 100755
> --- c/t/t6137-pathspec-wildcards-literal.sh
> +++ w/t/t6137-pathspec-wildcards-literal.sh
> @@ -4,7 +4,7 @@ test_description='test wildcards and literals with git add/commit (subshell styl
>  . ./test-lib.sh
>  
>  test_have_prereq BSLASHPSPEC || {
> -	skip_all='skipping: needs BSLASHPSPEC (backslashes in pathspecs)'
> +	skip_all='missing BSLASHPSPEC (backslashes in pathspecs)'
>  	test_done
>  }
>  
LGTM. Thanks!

ATB, Ramsay Jones

Previous: Junio C Hamano
Message 3 of 3 in “t6137-*.sh: fix test failure on cygwin”
  1. t6137-*.sh: fix test failure on cygwinRamsay Jones, Aug 8, 2025
  2. Junio C HamanoAug 8, 2025
  3. Ramsay JonesAug 9, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.