Re: [PATCH 0/8] Simple IPC Cleanups

From: Jeff Hostetler <git@jeffhostetler.com>
Date: Mar 5, 2021, 21:34 UTC
Message-ID: <8ea6401c-6ee6-94cb-4e33-9dfffaf466e8@jeffhostetler.com>
In-Reply-To: <xmqqlfb2bg6c.fsf@gitster.c.googlers.com>

On 3/4/21 7:24 PM, Junio C Hamano wrote:

Show 22 quoted lines

> sparse failed seen, so I tentatively added this on top of your
> series.
> 
> Thanks.
> 
>   t/helper/test-simple-ipc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/t/helper/test-simple-ipc.c b/t/helper/test-simple-ipc.c
> index 4da63fd30c..42040ef81b 100644
> --- a/t/helper/test-simple-ipc.c
> +++ b/t/helper/test-simple-ipc.c
> @@ -227,7 +227,7 @@ struct cl_args
>   	char bytevalue;
>   };
>   
> -struct cl_args cl_args = {
> +static struct cl_args cl_args = {
>   	.subcommand = NULL,
>   	.path = "ipc-test",
>   	.token = NULL,
>

Thanks!!

I'll update my copy.

Since things are settling down on the whole simple-ipc series and we are waiting for the current release cycle to complete before going any further, I'm going to let this series rest for a bit in case there are any more comments.

Then I'll combine the 2 parts and rebase/re-roll all of this into a single series that we can re-eval for "next" post 2.31.

Jeff