git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] commit-reach: create repo_is_descendant_of()

From
Derrick Stolee <stolee@gmail.com>
Date
Jun 30, 2020, 01:45 UTC
Message-ID
<8dc7ae37-8587-b055-d18f-75a153129026@gmail.com>
In-Reply-To
<20200629134035.GA59624@syl.lan>
On 6/29/2020 9:40 AM, Taylor Blau wrote:
Show 14 quoted lines
> On Wed, Jun 17, 2020 at 05:24:28PM +0000, Derrick Stolee via GitGitGadget wrote:
>> +int is_descendant_of(struct commit *commit, struct commit_list *with_commit)
>> +{
>> +	return repo_is_descendant_of(the_repository, commit, with_commit);
>> +}
>> +
> 
> I don't think that it makes a big deal either way, but I wonder about
> moving 'repo_is_descendant_of' to the header file, and making
> 'is_descendant_of' be 'static inline int' as you defined it here.
> 
> Since this has already graduated up to master already, I don't think
> that it's worth going back just to shuffle this code around, but I was
> wondering if you had any specific reason for doing it this way.
I have good news for you. [1]
[1] https://lore.kernel.org/git/20200623184222.54201-1-carenas@gmail.com/

Thanks, -Stolee

Previous: Taylor BlauNext: Derrick Stolee via GitGitGadget
Message 4 of 8 in “Accelerate "git merge-base --is-ancestor"”
  1. 0/2 Accelerate "git merge-base --is-ancestor"Derrick Stolee via GitGitGadget, Jun 17, 2020
  2. 1/2 commit-reach: create repo_is_descendant_of()Derrick Stolee via GitGitGadget, Jun 17, 2020
  3. Taylor BlauJun 29, 2020
  4. Derrick StoleeJun 30, 2020
  5. 2/2 commit-reach: use fast logic in repo_in_merge_baseDerrick Stolee via GitGitGadget, Jun 17, 2020
  6. Junio C HamanoJun 17, 2020
  7. Derrick StoleeJun 18, 2020
  8. Abhishek KumarJun 19, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.