git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/2] t9129: skip UTF-8 tests on Windows

From
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
Date
Sep 13, 2026, 19:11 UTC
Message-ID
<8d065f1b4f6f2a40cd9154cac460ef9dbc959488.1789326667.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.2227.git.1789326667.gitgitgadget@gmail.com>
From: Johannes Schindelin <johannes.schindelin@gmx.de>

The assumption of this test is that Perl and Git have the same idea how to perform encoding conversions.

However, in Git for Windows, Git is a native Win32 program, and such programs have a very different concept of encodings (called "Code Pages", and they are not controlled via environment variables at all), whereas the Perl interpreter used in Git for Windows is a pseudo-Unix one that uses the MSYS2 runtime (which _does_ try very much to abide by Unix' `LC_ALL` and friends, and totally ignores Windows' current or active code pages).

As such, these test cases _cannot_ work with Git for Windows. So let's just skip them on that platform.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 t/t9129-git-svn-i18n-commitencoding.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t9129-git-svn-i18n-commitencoding.sh b/t/t9129-git-svn-i18n-commitencoding.sh
index 01e1e8a8f7..f72a425dc1 100755
--- a/t/t9129-git-svn-i18n-commitencoding.sh
+++ b/t/t9129-git-svn-i18n-commitencoding.sh
@@ -71,7 +71,7 @@ do
 	'
 done
 
-test_expect_success UTF8 'ISO-8859-1 should match UTF-8 in svn' '
+test_expect_success UTF8,!MINGW 'ISO-8859-1 should match UTF-8 in svn' '
 	(
 		cd ISO8859-1 &&
 		compare_svn_head_with "$TEST_DIRECTORY"/t3900/1-UTF-8.txt
@@ -80,7 +80,7 @@ test_expect_success UTF8 'ISO-8859-1 should match UTF-8 in svn' '
 
 for H in eucJP ISO-2022-JP
 do
-	test_expect_success UTF8 "$H should match UTF-8 in svn" '
+	test_expect_success UTF8,!MINGW "$H should match UTF-8 in svn" '
 		(
 			cd $H &&
 			compare_svn_head_with "$TEST_DIRECTORY"/t3900/2-UTF-8.txt
-- 
gitgitgadget
Previous: Johannes Schindelin via GitGitGadget
Message 3 of 3 in “mingw: fix perl related test failures”
  1. 0/2 mingw: fix perl related test failuresJohannes Schindelin via GitGitGadget, Sep 13, 2026
  2. 1/2 t9700: accommodate for MSYS2 Perl reporting as `cygwin`Johannes Schindelin via GitGitGadget, Sep 13, 2026
  3. 2/2 t9129: skip UTF-8 tests on WindowsJohannes Schindelin via GitGitGadget, Sep 13, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.