Re: disabling sha1dc unaligned access, was Re: One failed self test on Fedora 29

From: Thomas Braun <thomas.braun@virtuell-zuhause.de>
Date: Mar 11, 2019, 18:15 UTC
Message-ID: <8cf2fa6c-d742-a2a6-cde7-66cef87b04e8@virtuell-zuhause.de>
In-Reply-To: <CACsJy8CdqbOKu7SHMt_Pz1EtRz08HGpwWHUHoZbUiow_pPh=+A@mail.gmail.com>

Am 11.03.2019 um 12:58 schrieb Duy Nguyen:

Show 8 quoted lines

> On Mon, Mar 11, 2019 at 10:48 AM Jeff King <peff@peff.net> wrote:
>> And AFAIK there is no good way to
>> modify the submodule-provided content as part of the build. Why do we
>> even have the submodule again? ;P
> 
> Because of dogfooding of course. This is an interesting use case
> though. I wonder if people often want to "patch" submodules like this
> (and what we could do if that's the case)

I usually do the following:

- Fork the sub-project
- Add a branch with my proposed patches
- Update the URL and the commit of the submodule in the super-project

This of course requires all users to do

git submodule sync

which is a bit incovenient, but works.