Re: [PATCH] dir: check for single file cone patterns

From: William Sprent <williams@unity3d.com>
Date: Dec 21, 2022, 12:51 UTC
Message-ID: <8c9650b7-8e36-909c-c193-2f6713427e57@unity3d.com>
In-Reply-To: <221220.86sfhaw3c3.gmgdl@evledraar.gmail.com>

On 20/12/2022 15.33, Ævar Arnfjörð Bjarmason wrote:

Show 10 quoted lines

> 
> On Tue, Dec 20 2022, William Sprent via GitGitGadget wrote:
> 
>> From: William Sprent <williams@unity3d.com>
>> [...]
>> +	if (!(given->flags & PATTERN_FLAG_MUSTBEDIR) &&
>> +	    !!strcmp(given->pattern, "/*")) {
> 
> Style: We use !! to convert 123 to 1 or whatever, but here we just care
> about "not matched", so we can drop this !!strcmp() for strcmp().

Thanks. I'll drop the '!!' for next version.