git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] Documentation/gitformat-pack.txt: fix typo

From
Taylor Blau <me@ttaylorr.com>
Date
Oct 12, 2023, 21:09 UTC
Message-ID
<8c5fa1ff4f1fc069094b5acbc70cd0808742fd24.1697144959.git.me@ttaylorr.com>
In-Reply-To
<cover.1697144959.git.me@ttaylorr.com>

e0d1bcf825 (multi-pack-index: add format details, 2018-07-12) describes the MIDX's "PNAM" chunk as having entries which are "null-terminated strings".

This is a typo, as strings are terminated with a NUL character, which is a distinct concept from "NULL" or "null", which we typically reserve for the void pointer to address 0.

Correct the documentation accordingly.
Signed-off-by: Taylor Blau <me@ttaylorr.com>
---
 Documentation/gitformat-pack.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/gitformat-pack.txt b/Documentation/gitformat-pack.txt
index 870e00f298..d7153962d4 100644
--- a/Documentation/gitformat-pack.txt
+++ b/Documentation/gitformat-pack.txt
@@ -390,7 +390,7 @@ CHUNK LOOKUP:
 CHUNK DATA:
 
 	Packfile Names (ID: {'P', 'N', 'A', 'M'})
-	    Stores the packfile names as concatenated, null-terminated strings.
+	    Stores the packfile names as concatenated, NUL-terminated strings.
 	    Packfiles must be listed in lexicographic order for fast lookups by
 	    name. This is the only chunk not guaranteed to be a multiple of four
 	    bytes in length, so should be the last chunk for alignment reasons.
-- 
2.42.0.349.gf0c1128f8b.dirty
Previous: Taylor BlauNext: Taylor Blau
Message 2 of 10 in “Documentation/gitformat-pack.txt: correct a few issues/typos”
  1. 0/2 Documentation/gitformat-pack.txt: correct a few issues/typosTaylor Blau, Oct 12, 2023
  2. 1/2 Documentation/gitformat-pack.txt: fix typoTaylor Blau, Oct 12, 2023
  3. 2/2 Documentation/gitformat-pack.txt: fix incorrect MIDX documentationTaylor Blau, Oct 12, 2023
  4. Junio C HamanoOct 12, 2023
  5. Taylor BlauOct 30, 2023
  6. Junio C HamanoOct 31, 2023
  7. 0/2 Documentation/gitformat-pack.txt: correct a few issues/typosTaylor Blau, Oct 31, 2023
  8. 1/2 Documentation/gitformat-pack.txt: fix typoTaylor Blau, Oct 31, 2023
  9. 2/2 Documentation/gitformat-pack.txt: fix incorrect MIDX documentationTaylor Blau, Oct 31, 2023
  10. Jeff KingOct 31, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.